Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Centralizes createWrapper for tests #16323

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[UI v2] feat: Centralizes createWrapper for tests #16323

merged 1 commit into from
Dec 10, 2024

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Dec 10, 2024 •
edited
Loading

Centralizes createWrapper for app-level providers for testing

Checklist

  1. Changes /mocks folder to /utils
  2. Adds createWrapper utility that can be re-used in our tests
  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Followup to #16319

@devinvillarosa devinvillarosa force-pushed the centralize-query-wrapper branch 2 times, most recently from de6522d to bccb615 Compare December 10, 2024 19:07
@devinvillarosa devinvillarosa force-pushed the centralize-query-wrapper branch from bccb615 to 708ecdd Compare December 10, 2024 19:09
@devinvillarosa devinvillarosa changed the title [UI v2] feat: Centralozes createWrapper for tests [UI v2] feat: Centralizes createWrapper for tests Dec 10, 2024
@devinvillarosa devinvillarosa marked this pull request as ready for review December 10, 2024 19:13
desertaxle
desertaxle approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@devinvillarosa devinvillarosa merged commit 6aaf035 into main Dec 10, 2024
14 checks passed
@devinvillarosa devinvillarosa deleted the centralize-query-wrapper branch December 10, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @desertaxle